From 0a94dd4658572f66a45587f4d109f5ab78dc0508 Mon Sep 17 00:00:00 2001 From: Rob Nelson Date: Mon, 17 May 2021 15:41:54 -0400 Subject: [PATCH] Better handling of module version checks If the module is not loaded, and autoloading does not occur before the `Get-HVModuleVersion` call, the result might be an empty string. This gives a chance to force loading the module and error if it is not available. --- Modules/VMware.Hv.Helper/VMware.HV.Helper.psm1 | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Modules/VMware.Hv.Helper/VMware.HV.Helper.psm1 b/Modules/VMware.Hv.Helper/VMware.HV.Helper.psm1 index 072cd05..b4c292d 100644 --- a/Modules/VMware.Hv.Helper/VMware.HV.Helper.psm1 +++ b/Modules/VMware.Hv.Helper/VMware.HV.Helper.psm1 @@ -55,7 +55,10 @@ function Get-ViewAPIService { } function Get-HVModuleVersion { - $hvModules = @( Get-Module -Name "Vmware.VimAutomation.HorizonView" -ErrorAction "SilentlyContinue" ); + if (-not (Get-Module -Name "Vmware.VimAutomation.HorizonView" -ErrorAction "SilentlyContinue") ) { + Import-Module -Name "Vmware.VimAutomation.HorizonView" -ErrorAction Stop + } + $hvModules = @( Get-Module -Name "Vmware.VimAutomation.HorizonView" -ErrorAction SilentlyContinue); return $($hvModules.version | measure -Maximum).Maximum }