voltron/PowerCLI-Example-Scripts
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Updates to Set-HVPool

Browse Source 
Updated Set-HVPool to address issue #132.  The -Start and -Stop parameter tested the wrong variable in the loop.  $item is undefined.  Furthermore, in general if the key/value pair specified $false as the value then the parameter wasn't seen in simple logic test such as if ($key -and $value) {}.  I've updated to use $PSBoundParameters instead.
This commit is contained in:
mtelvers
2017-10-27 08:52:44 +01:00
parent dfd5a4e37e
commit c2f137c812
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
Modules/VMware.Hv.Helper/VMware.HV.Helper.psm1
View File

@@ -5965,8 +5965,8 @@ function Set-HVPool {
} }
if ($desktopPools) { if ($desktopPools) {
foreach ($desktopObj in $desktopPools) { foreach ($desktopObj in $desktopPools) {
if (($Start -or $Stop) -and ("AUTOMATED" -ne $item.DesktopSummaryData.Type)) { if (($Start -or $Stop) -and ("AUTOMATED" -ne $desktopObj.DesktopSummaryData.Type)) {
Write-Error "Start/Stop operation is not supported for Poll with name : [$item.DesktopSummaryData.Name]" Write-Error "Start/Stop operation is not supported for Pool with name : [$desktopObj.DesktopSummaryData.Name]"
return return
} }
$poolList.add($desktopObj.id, $desktopObj.DesktopSummaryData.Name) $poolList.add($desktopObj.id, $desktopObj.DesktopSummaryData.Name)
@@ -5999,9 +5999,9 @@ function Set-HVPool {
} }
} }
$updates = @() $updates = @()
if ($key -and $value) { if ($PSBoundParameters.ContainsKey("key") -and $PSBoundParameters.ContainsKey("value")) {
$updates += Get-MapEntry -key $key -value $value $updates += Get-MapEntry -key $key -value $value
} elseif ($key -or $value) { } elseif ($PSBoundParameters.ContainsKey("key") -or $PSBoundParameters.ContainsKey("value")) {
Write-Error "Both key:[$key] and value:[$value] needs to be specified" Write-Error "Both key:[$key] and value:[$value] needs to be specified"
} }
if ($spec) { if ($spec) {