From 754e9300ebdf49c417d67de8732f2baa6919804c Mon Sep 17 00:00:00 2001 From: mtelvers Date: Mon, 16 Oct 2017 10:03:30 +0100 Subject: [PATCH] Updates to New-HVPool Removed parameter -Deleting which isn't used and is a read-only property anyway Corrected automatic Logoff Minutes validation range which is 1.. rather than 1..120 Updated the validation set for delete or refresh machines after log off. From the API, valid options are Never, Delete, Refresh not Never, Delete, After Allowed selecting the AD Container when creating Linked Clones --- Modules/VMware.Hv.Helper/VMware.HV.Helper.psm1 | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/Modules/VMware.Hv.Helper/VMware.HV.Helper.psm1 b/Modules/VMware.Hv.Helper/VMware.HV.Helper.psm1 index 058f979..25c64a5 100644 --- a/Modules/VMware.Hv.Helper/VMware.HV.Helper.psm1 +++ b/Modules/VMware.Hv.Helper/VMware.HV.Helper.psm1 @@ -3568,10 +3568,6 @@ function New-HVPool { [string[]] $ConnectionServerRestrictions, - #desktopSpec.desktopSettings.deleting - [Parameter(Mandatory = $false,ParameterSetName = "LINKED_CLONE")] - [boolean]$Deleting = $false, - #desktopSpec.desktopSettings.logoffSettings.powerPloicy [Parameter(Mandatory = $false,ParameterSetName = "LINKED_CLONE")] [ValidateSet('TAKE_NO_POWER_ACTION', 'ALWAYS_POWERED_ON', 'SUSPEND', 'POWER_OFF')] @@ -3584,7 +3580,7 @@ function New-HVPool { #desktopSpec.desktopSettings.logoffSettings.automaticLogoffMinutes [Parameter(Mandatory = $false,ParameterSetName = "LINKED_CLONE")] - [ValidateRange(1,120)] + [ValidateRange(1,[int]::MaxValue)] [int]$AutomaticLogoffMinutes = 120, #desktopSpec.desktopSettings.logoffSettings.allowUsersToResetMachines @@ -3597,7 +3593,7 @@ function New-HVPool { #desktopSpec.desktopSettings.logoffSettings.deleteOrRefreshMachineAfterLogoff [Parameter(Mandatory = $false,ParameterSetName = "LINKED_CLONE")] - [ValidateSet('NEVER', 'DELETE', 'AFTER')] + [ValidateSet('NEVER', 'DELETE', 'REFRESH')] [string]$deleteOrRefreshMachineAfterLogoff = 'NEVER', #desktopSpec.desktopSettings.logoffSettings.refreshOsDiskAfterLogoff @@ -3961,8 +3957,9 @@ function New-HVPool { [int] $NumUnassignedMachinesKeptPoweredOn = 1, - #desktopSpec.automatedDesktopSpec.customizationSettings.cloneprepCustomizationSettings.instantCloneEngineDomainAdministrator if INSTANT_CLONE + #desktopSpec.automatedDesktopSpec.customizationSettings.AdContainer [Parameter(Mandatory = $false,ParameterSetName = 'INSTANT_CLONE')] + [Parameter(Mandatory = $false,ParameterSetName = 'LINKED_CLONE')] $AdContainer = 'CN=Computers', [Parameter(Mandatory = $true,ParameterSetName = 'INSTANT_CLONE')]