From cda9bd36e1d62e76897d10492ef6d1b808c286af Mon Sep 17 00:00:00 2001 From: Wouter Kursten Date: Mon, 26 Feb 2018 22:01:33 +0100 Subject: [PATCH 1/2] replaced return of vcenter vm id's replaced some return of vcenter vm id's that gave back some hardly usefull information to the user. Now it gives a successfully add... message --- Modules/VMware.Hv.Helper/VMware.HV.Helper.psm1 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Modules/VMware.Hv.Helper/VMware.HV.Helper.psm1 b/Modules/VMware.Hv.Helper/VMware.HV.Helper.psm1 index 4307df3..2119484 100644 --- a/Modules/VMware.Hv.Helper/VMware.HV.Helper.psm1 +++ b/Modules/VMware.Hv.Helper/VMware.HV.Helper.psm1 @@ -309,7 +309,7 @@ The Add-HVDesktop adds virtual machines to already exiting pools by using view A if (!$confirmFlag -OR $pscmdlet.ShouldProcess($machines)) { $desktop_service_helper.Desktop_AddMachinesToManualDesktop($services,$id,$machineList) } - return $machineList + write-host "Successfully added desktop(s) to pool" } default { Write-Error "Only Automated/Manual pool types support this add operation" @@ -448,7 +448,7 @@ function Add-HVRDSServer { if (!$confirmFlag -OR $pscmdlet.ShouldProcess($rdsServers)) { $farm_service_helper.Farm_AddRDSServers($services, $id, $serverList) } - return $serverList + write-host "Successfully added RDS Server(s) to Farm" } catch { Write-Error "Failed to Add RDS Server to Farm with error: $_" break From 9282c79c86afa10f99612bae6b3fcb8f07c81aeb Mon Sep 17 00:00:00 2001 From: Wouter Kursten Date: Sat, 3 Mar 2018 10:23:22 +0100 Subject: [PATCH 2/2] getnext placed on the wrong spot --- Modules/VMware.Hv.Helper/VMware.HV.Helper.psm1 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Modules/VMware.Hv.Helper/VMware.HV.Helper.psm1 b/Modules/VMware.Hv.Helper/VMware.HV.Helper.psm1 index 2119484..5c5916e 100644 --- a/Modules/VMware.Hv.Helper/VMware.HV.Helper.psm1 +++ b/Modules/VMware.Hv.Helper/VMware.HV.Helper.psm1 @@ -9198,10 +9198,10 @@ $query_service_helper = New-Object VMware.Hv.GlobalSessionQueryServiceService $query=new-object vmware.hv.GlobalSessionQueryServiceQuerySpec $SessionList = @() -$GetNext = $false foreach ($pod in $services.Pod.Pod_List()) { $query.pod=$pod.id $queryResults = $query_service_helper.GlobalSessionQueryService_QueryWithSpec($services, $query) + $GetNext = $false do { if ($GetNext) { $queryResults = $query_service_helper.GlobalSessionQueryService_GetNext($services, $queryResults.id) } $SessionList += $queryResults.results